Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to reflect dem resolution defaults #1683

Merged
merged 5 commits into from
Jul 29, 2023

Conversation

smathermather
Copy link
Contributor

Also ignore ignore-gsd, but also don't advertise it in orthophoto resolution. Replaces OpenDroneMap/docs#176 (comment)

Also ignore ignore-gsd, but also don't advertise it in orthophoto resolution. Replaces OpenDroneMap/docs#176 (comment)
For elevation models too!
Copy link
Contributor

@Saijin-Naib Saijin-Naib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me.

Something about the existing help text for ignore-gsd in general doesn't read well to me, but I need to audit what it does to make sure I'm not just misunderstanding. It almost seems to imply that it would be a good option to pass for memory-limited systems, which it really is not.

Copy link
Contributor

@Saijin-Naib Saijin-Naib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This, I think, reads much more true to the behavior and might help some folks not step into this particular stumbling block.

@smathermather smathermather merged commit d929d7b into OpenDroneMap:master Jul 29, 2023
1 of 2 checks passed
@smathermather smathermather deleted the dem-resolution-et-al branch July 29, 2023 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants